store client information on storageconsumer status #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leelavg
commented
Sep 22, 2023
leelavg
commented
- adds new fields to existing RPC message
- these fields are updated in status of corresponding storageconsumer CRs
- the status will be helpful for exporting new metrics
leelavg
force-pushed
the
csi-metrics
branch
from
44d8198 to
498cb8d
Compare
leelavg
force-pushed
the
csi-metrics
branch
3 times, most recently
from
54dd712 to
33f6269
Compare
leelavg
force-pushed
the
csi-metrics
branch
3 times, most recently
from
15eb8c5 to
69e82b4
Compare
rewantsoni
reviewed
Oct 18, 2023
iamniting
requested changes
Oct 19, 2023
|
I think we also need to update the PR title and commit msg as I don't see any metrics work done here. |
leelavg
changed the title
nb-ohad
requested changes
Oct 23, 2023
leelavg
force-pushed
the
csi-metrics
branch
2 times, most recently
from
cde722b to
a8e0495
Compare
Madhu-1
reviewed
Oct 25, 2023
leelavg
force-pushed
the
csi-metrics
branch
2 times, most recently
from
594fcb6 to
cda1bf5
Compare
nb-ohad
requested changes
Oct 29, 2023
leelavg
force-pushed
the
csi-metrics
branch
2 times, most recently
from
5979a58 to
6b2cc7a
Compare
nb-ohad
requested changes
Oct 30, 2023
nb-ohad
requested changes
Oct 30, 2023
nb-ohad
force-pushed
the
fusion-hci-4.14
branch
from
7d4fda1 to
9fbb0c7
Compare
|
/lgtm |
openshift-ci
bot
added
lgtm
|
@iamniting quick check, any idea why verify-latest-csv failing in CI, it's passing for me locally Edit: Force push worked, pls disregard. |
- adds new fields to existing RPC message - these fields are updated in status of corresponding storageconsumer CRs - the status will be helpful for exporting new metrics Signed-off-by: Leela Venkaiah G <[email protected]>
iamniting
requested changes
Oct 31, 2023
iamniting
approved these changes
Oct 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, leelavg, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit 5ea7bff
into
red-hat-storage:fusion-hci-4.14
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.